[PoC][pdata/pcommon] - Enhance FromRaw method #13810
Closed
+54
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13810 +/- ##
==========================================
- Coverage 91.42% 91.38% -0.05%
==========================================
Files 640 640
Lines 42599 42687 +88
==========================================
+ Hits 38946 39008 +62
- Misses 2834 2857 +23
- Partials 819 822 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances
FromRawmethod to support:[]string, it will fail. But we support thestringtypemap[string]anyas the underlying type.map[string]anytime.Timeby converting it to a ISO 8601 format string.I'm happy to hear @bogdandrutu and @dmitryax's thoughts on this enhancement.
Testing
Will add testing if we decide to go forward with this change.